Skip to content

Conversation

@eshitachandwani
Copy link
Member

Part of A74 changes.
This PR add the functions and functionalities to be used for cluster subscription for cluster refcounts and also for dynamic cluster subscription. These functions will be used in subsequent PRs.
RELEASE NOTES: None

@eshitachandwani eshitachandwani added this to the 1.79 Release milestone Dec 26, 2025
@eshitachandwani eshitachandwani added Type: Internal Cleanup Refactors, etc Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Dec 26, 2025
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

❌ Patch coverage is 67.34694% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (629ef39) to head (2efe5da).

Files with missing lines Patch % Lines
internal/xds/xdsdepmgr/xds_dependency_manager.go 63.41% 12 Missing and 3 partials ⚠️
internal/xds/resolver/xds_resolver.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8792      +/-   ##
==========================================
+ Coverage   83.22%   83.29%   +0.07%     
==========================================
  Files         417      417              
  Lines       32920    32963      +43     
==========================================
+ Hits        27397    27457      +60     
+ Misses       4108     4100       -8     
+ Partials     1415     1406       -9     
Files with missing lines Coverage Δ
internal/xds/resolver/xds_resolver.go 88.70% <87.50%> (-0.06%) ⬇️
internal/xds/xdsdepmgr/xds_dependency_manager.go 79.74% <63.41%> (-0.68%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arjan-bal
arjan-bal previously approved these changes Jan 7, 2026
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise LGTM!

@arjan-bal arjan-bal dismissed their stale review January 7, 2026 21:05

Questions regarding the cluster subscription API.

Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants