[CIR] Relax CastOp verifier for scalar bitcasts #2086
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax CastOp verification to allow scalar-to-scalar bitcasts when the source and result types have identical DataLayout sizes. This enables builtin as_type-style conversions (e.g. float <-> int) to be represented as cir.cast bitcast operations without being rejected by the verifier.
mahmood82
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
requested changes
Jan 12, 2026
| return success(); | ||
| } | ||
|
|
||
| + // Allow scalar-to-scalar bitcasts if they have the same size |
Member
There was a problem hiding this comment.
This is probably not intentional?
| } | ||
|
|
||
| // Allow scalar-to-scalar bitcasts if they have the same size | ||
| if (!mlir::isa<cir::VectorType>(srcType) && |
Member
There was a problem hiding this comment.
Please use cir::isScalarType, should be available via CIRTypes.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax CastOp verification to allow scalar-to-scalar bitcasts when the source and result types have identical DataLayout sizes. This enables builtin as_type-style conversions (e.g. float <-> int) to be represented as cir.cast bitcast operations without being rejected by the verifier.