[CIR] Preserve address space when bitcasting pointers #2089
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CIRGenBuilder to propagate the source pointer address space when bitcasting to a different pointee type. This avoids dropping or recomputing address spaces during pointer re-typing and matches LLVM IR behavior.
mahmood82
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
approved these changes
Jan 12, 2026
|
|
||
| auto ptrTy = getPointerTo(destType); | ||
| return Address(createBitcast(loc, addr.getPointer(), ptrTy), destType, | ||
| auto ptrTy = mlir::dyn_cast<cir::PointerType>(addr.getPointer().getType()); |
Member
There was a problem hiding this comment.
If you are 100% sure this is a PointerType just use cast instead of dyn_cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CIRGenBuilder to propagate the source pointer address space when bitcasting to a different pointee type. This avoids dropping or recomputing address spaces during pointer re-typing and matches LLVM IR behavior.