[Shopify] Fix wrong Refund Line ID being used #6105
+23
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where the Shopify Connector was incorrectly using the Order Line ID instead of the actual Refund Line ID when creating refund line records. The issue caused incorrect data to be stored in the
"Refund Line Id"field of the"Shpfy Refund Line"table.Problem
When importing refund lines from Shopify, the system was extracting the
lineItem.idfrom the GraphQL response and using it as both the"Refund Line Id"and"Order Line Id". This was incorrect because:lineItem.idrepresents the original order line item"Refund Line Id"Solution
Updated GraphQL queries to include the
idfield for refund line items:idto thenodesselectionidto thenodesselectionUpdated the refund line import logic in ShpfyRefundsAPI.Codeunit.al:
idfor the"Refund Line Id"fieldlineItem.idonly for the"Order Line Id"field (the reference to the original order line)Work Item(s)
Fixes AB#617843